Add tls config to etcd metadata driver#3978
Open
alesharik wants to merge 4 commits intoapache:masterfrom
Open
Conversation
Contributor
|
Please fix checkstyle errors to let CI run |
Author
|
@dlg99 done, checkstyle errors fixed |
zymap
approved these changes
Jun 12, 2023
hangc0276
approved these changes
Jun 13, 2023
Member
|
@alesharik Thanks for your contribution. Any updates? |
Author
|
@shoothzj it is ready. CI failed because of other error, and it may be fixed now |
hezhangjian
reviewed
May 4, 2024
| @@ -0,0 +1 @@ | |||
| cfssl | |||
Member
There was a problem hiding this comment.
why we need this in .gitignore
Member
|
@alesharik Sorry for my late reply, I recenlty come back to actively work in BookKeeper project. I think we also need documentation about how to config like in #4256 . Also you need to rebase the code, so we can move forward with this PR. Thanks for your contribution. cc @dlg99 @eolivelli |
Contributor
|
@alesharik please add some documentation, rebase, and make sure that the CI passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Etcd metadata driver should support TLS connections to etcd.
Changes
metadataServiceConfigconfig parameter to specify the path for the metadata service configuration fileEtcdConfigto parse metadata service configuration file and extract TLS config from itEtcdMetadataDriverBase